gjjjj0101 commented on code in PR #1966:
URL: https://github.com/apache/hertzbeat/pull/1966#discussion_r1597568960
##########
collector/src/test/java/org/apache/hertzbeat/collector/collect/redfish/RedfishCollectImplTest.java:
##########
@@ -77,88 +79,96 @@ void mockCollect() throws Exception {
CollectRep.MetricsData.Builder builder =
CollectRep.MetricsData.newBuilder();
List<String> aliasField = new ArrayList<>();
aliasField.add("$.['@odata.id']");
-
redfishProtocol.setSchema("/redfish/v1/Chassis/{ChassisId}/PowerSubsystem/PowerSupplies");
+
redfishProtocol.setSchema("/redfish/v1/chassis/{ChassisId}/PowerSubsystem/PowerSupplies");
Review Comment:
Hi, redifshProtocol schema field means the Resource collection URI which you
want to monitor. Users can refer to
[DSP0268](https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2023.3.pdf)
Section 5.2 content to find the according Resource collection URI. So in this
test, we want to monitor PowerSupplies in PowerSupplyCollection. Refer to the
table, the according URI is
"/redfish/v1/Chassis/{ChassisId}/PowerSubsystem/PowerSupplies". So I think
"Chassis" with capital “C” is correct, misspelled test cases may confuse
developers. Sorry for not providing detailed documentation explaining usage
details. I will impove the redfish collect and complete documentation soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
