LiuTianyou commented on PR #2040: URL: https://github.com/apache/hertzbeat/pull/2040#issuecomment-2137634377
> > 1. added ci for filename checking following documentation contribution guidelines. > > so sorry i made a mistake for the confusion. Can we update the contribution guidelines and support this file name format? @tomsun28 That's a good idea, it will result in fewer changes and be more secure. I will close this PR and create a new one after making the modifications. Thank you for your suggestion. When I was making the changes, I was also concerned that it might affect users viewing the help documentation in previous versions. After my modifications, I tested it and confirmed that if the ID is defined in the document, the document link is not affected by the filename. I apologize for not mentioning this in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
