Calvin979 commented on PR #2072: URL: https://github.com/apache/hertzbeat/pull/2072#issuecomment-2156020317
> hi thanks lgtm !👍👍 Suggest we can combine the `ip` and `public ip` into one `ip`. When user custom config the collector `ip` like below, we use the custom ip, else we use the ip we detect by program like before. > > ```yaml > collector: > info: > version: 1.5.0 > ip: 38.44.3.5 > ``` Code has been updated by your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
