This is an automated email from the ASF dual-hosted git repository.
zhaoqingran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hertzbeat.git
The following commit(s) were added to refs/heads/master by this push:
new 6cabe3ca0 Further enhance and refine the optimizations implemented in
#2215. (#2249)
6cabe3ca0 is described below
commit 6cabe3ca0ccb67fbc3b27f92945e12ced6094535
Author: Kerwin Bryant <[email protected]>
AuthorDate: Tue Jul 9 16:19:06 2024 +0800
Further enhance and refine the optimizations implemented in #2215. (#2249)
Signed-off-by: Kerwin Bryant <[email protected]>
---
.../routes/monitor/monitor-form/monitor-form.component.html | 6 +-----
.../app/routes/monitor/monitor-form/monitor-form.component.ts | 10 ++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git
a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
index 2cbb02005..d163ca445 100644
--- a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
+++ b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
@@ -58,11 +58,7 @@
/>
</ng-container>
- <nz-collapse
- *ngIf="advancedParamDefines && advancedParamDefines.length > 0"
- [nzGhost]="true"
- style="background: ghostwhite; margin-bottom: 24px"
- >
+ <nz-collapse *ngIf="hasAdvancedParams" [nzGhost]="true"
style="background: ghostwhite; margin-bottom: 24px">
<ng-template #extraColHeader>
<button style="margin-left: 40%" nz-button nzType="dashed"
nz-tooltip [nzTooltipTitle]="'monitors.advanced.tip' | i18n">
<span>{{ 'monitors.advanced' | i18n }}</span>
diff --git
a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
index c2b963ca6..963ed4fd3 100644
--- a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
+++ b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
@@ -47,9 +47,19 @@ export class MonitorFormComponent implements OnChanges {
@Output() readonly formDetect = new EventEmitter<any>();
@Output() readonly hostChange = new EventEmitter<string>();
+ hasAdvancedParams: boolean = false;
+
constructor() {}
ngOnChanges(changes: SimpleChanges) {
+ if (changes.advancedParams && changes.advancedParams.currentValue !==
changes.advancedParams.previousValue) {
+ for (const advancedParam of changes.advancedParams.currentValue) {
+ if (advancedParam.display !== false) {
+ this.hasAdvancedParams = true;
+ break;
+ }
+ }
+ }
if (changes.paramDefines && changes.paramDefines.currentValue !==
changes.paramDefines.previousValue) {
changes.paramDefines.currentValue.forEach((paramDefine: any) => {
if (paramDefine.type == 'radio') {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
