kerwin612 commented on code in PR #2311:
URL: https://github.com/apache/hertzbeat/pull/2311#discussion_r1684061786
##########
web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html:
##########
@@ -107,6 +107,7 @@
[extra]="{collectors}"
[name]="'collector'"
[(ngModel)]="collector"
+ (ngModelChange)="onCollectorChange($event)"
Review Comment:
https://github.com/apache/hertzbeat/blob/91111e55550d7d46a007db2f483b02a2dcd0a1a0/web-app/src/app/routes/monitor/monitor-new/monitor-new.component.ts#L168
https://github.com/apache/hertzbeat/blob/91111e55550d7d46a007db2f483b02a2dcd0a1a0/web-app/src/app/routes/monitor/monitor-edit/monitor-edit.component.ts#L193
Changing "`this.collector`" to "`info.collector`" in these two lines seems
to be able to meet your requirement.
##########
web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html:
##########
@@ -107,6 +107,7 @@
[extra]="{collectors}"
[name]="'collector'"
[(ngModel)]="collector"
+ (ngModelChange)="onCollectorChange($event)"
Review Comment:
There is no need to add a new event; if necessary, you can get the new value
in the submit callback;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
