This is an automated email from the ASF dual-hosted git repository.
gongchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hertzbeat.git
The following commit(s) were added to refs/heads/master by this push:
new 43afb0bc6 [type:fix] fix empty value not be handled by custom metrics
(#2323)
43afb0bc6 is described below
commit 43afb0bc63b912ae69423b972e6788e32198e37d
Author: aias00 <[email protected]>
AuthorDate: Sun Jul 21 17:11:02 2024 +0800
[type:fix] fix empty value not be handled by custom metrics (#2323)
Co-authored-by: tomsun28 <[email protected]>
---
.../hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java | 4 ----
.../hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java | 5 +----
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git
a/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java
b/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java
index 9f28bcf78..7ad9ed092 100644
---
a/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java
+++
b/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java
@@ -72,10 +72,6 @@ public class MemoryDataStorage extends
AbstractRealTimeDataStorage {
if (metricsData.getCode() != CollectRep.Code.SUCCESS) {
return;
}
- if (metricsData.getValuesList().isEmpty()) {
- log.debug("[warehouse memory] memory flush metrics data {} is
null, ignore.", metricsData.getId());
- return;
- }
Map<String, CollectRep.MetricsData> metricsDataMap =
monitorMetricsDataMap.computeIfAbsent(monitorId, key -> new
ConcurrentHashMap<>(METRICS_SIZE));
metricsDataMap.put(metrics, metricsData);
}
diff --git
a/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java
b/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java
index 12ce78738..371222a3e 100644
---
a/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java
+++
b/warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java
@@ -79,10 +79,7 @@ public class RedisDataStorage extends
AbstractRealTimeDataStorage {
if (metricsData.getCode() != CollectRep.Code.SUCCESS ||
!isServerAvailable()) {
return;
}
- if (metricsData.getValuesList().isEmpty()) {
- log.info("[warehouse redis] redis flush metrics data {} - {} is
null, ignore.", key, hashKey);
- return;
- }
+
RedisAsyncCommands<String, CollectRep.MetricsData> commands =
connection.async();
commands.select(db);
commands.hset(key, hashKey, metricsData).thenAccept(response -> {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
