kerwin612 opened a new pull request, #2332: URL: https://github.com/apache/hertzbeat/pull/2332
## What's changed? (https://github.com/apache/hertzbeat/blob/712c54186e2341b2e9a771174e79be60c27651ef/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java#L384) https://github.com/apache/hertzbeat/blob/712c54186e2341b2e9a771174e79be60c27651ef/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java#L521 https://github.com/apache/hertzbeat/blob/712c54186e2341b2e9a771174e79be60c27651ef/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java#L590 https://github.com/apache/hertzbeat/blob/712c54186e2341b2e9a771174e79be60c27651ef/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/AppServiceImpl.java#L642 From the above four lines of code, we can see that the [app] in the list data is all in lower-case; Therefore, there will be a problem when the front-end tries to obtain i18n using an unprocessed (not uniformly converted to lower-case) [app]. https://github.com/apache/hertzbeat/blob/712c54186e2341b2e9a771174e79be60c27651ef/web-app/src/app/routes/alert/alert-setting/alert-setting.component.html#L112 ## Checklist - [x] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide) - [x] I have written the necessary doc or comment. - [x] I have added the necessary unit tests and all cases have passed. ## Add or update API - [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
