tomsun28 commented on code in PR #2337:
URL: https://github.com/apache/hertzbeat/pull/2337#discussion_r1686736176
##########
collector/src/main/java/org/apache/hertzbeat/collector/dispatch/export/NettyDataQueue.java:
##########
@@ -76,4 +76,9 @@ public CollectRep.MetricsData
pollMetricsDataToRealTimeStorage() throws Interrup
public void sendMetricsData(CollectRep.MetricsData metricsData) {
collectJobService.sendAsyncCollectData(metricsData);
}
+
+ @Override
+ public void destroy() throws Exception {
+ }
+
Review Comment:
Hi, if update the location of DisposableBean, this will be redundant. I
don't think this is an optimization point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
