Calvin979 commented on code in PR #2399: URL: https://github.com/apache/hertzbeat/pull/2399#discussion_r1694287808
########## common/src/main/java/org/apache/hertzbeat/common/constants/SmsTypeEnum.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hertzbeat.common.constants; + +/** + * Sms type Enum + */ +public enum SmsTypeEnum { + + /** + * tencent sms + */ + tencent, + + /** + * alibaba sms + */ + alibaba; + + /** + * get type + */ + public static SmsTypeEnum getTypeByName(String type) { + for (SmsTypeEnum smsTypeEnum : values()) { + if (smsTypeEnum.name().equals(type)) { + return smsTypeEnum; + } + + } + return null; Review Comment: Suggest use `stream().anyMatch()` to simplify code ########## common/src/main/java/org/apache/hertzbeat/common/constants/SmsTypeEnum.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hertzbeat.common.constants; + +/** + * Sms type Enum + */ +public enum SmsTypeEnum { + + /** + * tencent sms + */ + tencent, Review Comment: Field in Enum should be uppercased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
