tomsun28 commented on code in PR #2439:
URL: https://github.com/apache/hertzbeat/pull/2439#discussion_r1701161085
##########
manager/pom.xml:
##########
@@ -145,7 +145,7 @@
<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
- <scope>provided</scope>
+<!-- <scope>provided</scope>-->
</dependency>
Review Comment:
hi the mysql dependency must be `<scope>provided</scope>`
Due to the Apache Foundation's requirements for license compliance,
HertzBeat's installation package cannot include dependencies with GPL licenses
such as MySQL, Oracle, etc. Users need to add them themselves. Users can
download the drivers from the following links and copy them to the ext-lib
directory of the installation.
refer https://hertzbeat.apache.org/docs/help/mysql, suggest add help doc
same with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
