This is an automated email from the ASF dual-hosted git repository.
gongchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hertzbeat.git
The following commit(s) were added to refs/heads/master by this push:
new 69b8db704 [improve] remove useless invoke method (#2450)
69b8db704 is described below
commit 69b8db7048ad7f0ca818037ce04bb31c9c686f39
Author: lingluojun <[email protected]>
AuthorDate: Sat Aug 3 23:32:46 2024 +0800
[improve] remove useless invoke method (#2450)
Co-authored-by: tomsun28 <[email protected]>
---
.../collector/dispatch/entrance/processor/GoOfflineProcessor.java | 1 -
.../org/apache/hertzbeat/remoting/netty/NettyRemotingAbstract.java | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/collector/src/main/java/org/apache/hertzbeat/collector/dispatch/entrance/processor/GoOfflineProcessor.java
b/collector/src/main/java/org/apache/hertzbeat/collector/dispatch/entrance/processor/GoOfflineProcessor.java
index 1e8dbb2b0..007b77053 100644
---
a/collector/src/main/java/org/apache/hertzbeat/collector/dispatch/entrance/processor/GoOfflineProcessor.java
+++
b/collector/src/main/java/org/apache/hertzbeat/collector/dispatch/entrance/processor/GoOfflineProcessor.java
@@ -41,7 +41,6 @@ public class GoOfflineProcessor implements
NettyRemotingProcessor {
}
timerDispatch.goOffline();
log.info("receive offline message and handle success");
- message.getMsg();
if (message.getMsg().contains(CommonConstants.COLLECTOR_AUTH_FAILED)) {
log.error("[Auth Failed]receive client auth failed message and go
offline. {}", message.getMsg());
return null;
diff --git
a/remoting/src/main/java/org/apache/hertzbeat/remoting/netty/NettyRemotingAbstract.java
b/remoting/src/main/java/org/apache/hertzbeat/remoting/netty/NettyRemotingAbstract.java
index 09b4dc4f4..a9632d7c4 100644
---
a/remoting/src/main/java/org/apache/hertzbeat/remoting/netty/NettyRemotingAbstract.java
+++
b/remoting/src/main/java/org/apache/hertzbeat/remoting/netty/NettyRemotingAbstract.java
@@ -26,6 +26,7 @@ import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.collections4.CollectionUtils;
import org.apache.hertzbeat.common.entity.message.ClusterMsg;
import org.apache.hertzbeat.common.util.NetworkUtil;
import org.apache.hertzbeat.remoting.RemotingService;
@@ -77,7 +78,7 @@ public abstract class NettyRemotingAbstract implements
RemotingService {
}
private void doBeforeRequest(ChannelHandlerContext ctx, ClusterMsg.Message
request) {
- if (this.nettyHookList == null || this.nettyHookList.isEmpty()) {
+ if (CollectionUtils.isEmpty(this.nettyHookList)) {
return;
}
for (NettyHook nettyHook : this.nettyHookList) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
