Calvin979 commented on code in PR #2435:
URL: https://github.com/apache/hertzbeat/pull/2435#discussion_r1703280681
##########
alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertsControllerTest.java:
##########
@@ -77,13 +76,7 @@ void getAlerts() throws Exception {
Page<Alert> alertPage = new
PageImpl<>(Collections.singletonList(Alert.builder().build()));
Mockito.when(
alertService.getAlerts(
- Mockito.any(Specification.class)
- , Mockito.argThat(
- argument ->
- argument.getPageNumber() ==
pageRequest.getPageNumber()
- &&
argument.getPageSize() == pageRequest.getPageSize()
- &&
argument.getSort().equals(pageRequest.getSort())
- )
+ ids, 1L, (byte) 1, (byte) 1, "test",
sortField, orderType, pageIndex, pageSize
Review Comment:
Nice work! Could you help fix this test. Unit tests are passed because this
test method is not annotated with `@Test`
##########
manager/src/main/resources/application.yml:
##########
@@ -18,7 +18,7 @@ spring:
application:
name: ${HOSTNAME:@hertzbeat@}${PID}
profiles:
- active: prod
+ active: pg
Review Comment:
Why modify `application.yml`? Looks like it is a dev configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
