yuluo-yx commented on PR #2454: URL: https://github.com/apache/hertzbeat/pull/2454#issuecomment-2268160368
yep. I think so. I am debug in my local. If has new discover, i will push. I will mark its draft later. tomsun28 ***@***.***>于2024年8月5日 周一12:37写道： > ***@***.**** commented on this pull request. > ------------------------------ > > In > alerter/src/main/java/org/apache/hertzbeat/alert/controller/AlertDefinesController.java > <https://github.com/apache/hertzbeat/pull/2454#discussion_r1703525285>: > > > - return ResponseEntity.ok(Message.success(alertDefinePage)); > + > + return ResponseEntity.ok(Message.success( > + new PageImpl<>( > + alertDefinePage.getContent(), > + PageRequest.of(pageIndex, pageSize, Sort.by(new Sort.Order(Sort.Direction.fromString(order), sort))), > + alertDefinePage.getTotalElements())) > + ); > > Hi, it maybe caused by test cases or other reasons. I feel that we cannot > repeat the construction like this. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hertzbeat/pull/2454#pullrequestreview-2217993592>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ASS2GCIP55OT2HPTIBFACADZP36RDAVCNFSM6AAAAABL6OCNHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJXHE4TGNJZGI> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
