Calvin979 commented on code in PR #2540: URL: https://github.com/apache/hertzbeat/pull/2540#discussion_r1720080566
########## warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/history/vm/VictoriaMetricsProperties.java: ########## @@ -17,13 +17,21 @@ package org.apache.hertzbeat.warehouse.store.history.vm; +import org.apache.hertzbeat.common.constants.ConfigConstants; +import org.apache.hertzbeat.common.constants.SignConstants; +import org.apache.hertzbeat.warehouse.constants.WarehouseConstants; import org.springframework.boot.context.properties.ConfigurationProperties; import org.springframework.boot.context.properties.bind.DefaultValue; /** * Victoriametrics configuration information */ -@ConfigurationProperties(prefix = "warehouse.store.victoria-metrics") + +@ConfigurationProperties(prefix = ConfigConstants.FunctionModuleConstants.WAREHOUSE + + SignConstants.DOT + + WarehouseConstants.STORE + + SignConstants.DOT + + WarehouseConstants.HistoryName.VM) Review Comment: inconsistent with the previous ########## warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/history/tdengine/TdEngineProperties.java: ########## @@ -29,7 +32,12 @@ * @param password tdengine password * @param tableStrColumnDefineMaxLength auto create table's string column define max length : NCHAR(200) */ -@ConfigurationProperties(prefix = "warehouse.store.td-engine") + +@ConfigurationProperties(prefix = ConfigConstants.FunctionModuleConstants.WAREHOUSE + + SignConstants.DOT + + WarehouseConstants.STORE + + SignConstants.DOT + + WarehouseConstants.HistoryName.TDENDINE) Review Comment: inconsistent with the previous ########## warehouse/src/main/java/org/apache/hertzbeat/warehouse/store/history/iotdb/IotDbProperties.java: ########## @@ -34,7 +35,12 @@ * Note: Why use String instead of Long here? Currently, IoTDB's set ttl only supports milliseconds as the unit. * Other units may be added later. In order to be compatible with the future, the String type is used. */ -@ConfigurationProperties(prefix = "warehouse.store.iot-db") + +@ConfigurationProperties(prefix = ConfigConstants.FunctionModuleConstants.WAREHOUSE + + SignConstants.DOT + + WarehouseConstants.STORE + + SignConstants.DOT + + WarehouseConstants.HistoryName.IOTDB) Review Comment: Looks like `WarehouseConstants.HistoryName.IOTDB` is inconsistent with the previous and there is no properties were changed in application.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
