This is an automated email from the ASF dual-hosted git repository. zhaoqingran pushed a commit to branch script in repository https://gitbox.apache.org/repos/asf/hertzbeat.git
commit b390a0dbc9fc728eb719074f0d8502e9c3bf89ce Author: zqr10159 <[email protected]> AuthorDate: Tue Sep 3 10:37:49 2024 +0800 ```refactor(script-executor): remove unused imports and commented code Remove unused imports and commented-out code related to ScriptLoadException and GraalVM's Source from Jsr223ScriptExecutor. Also, clean up dead code in PluginUpload DTO by removing commented-out Collector association. This change helps to maintain a cleaner codebase by eliminating unnecessary parts, which can improve readability and reduce potential confusion about the code's purpose. ``` --- .../java/org/apache/hertzbeat/common/entity/dto/PluginUpload.java | 5 ++--- .../hertzbeat/common/script/executor/Jsr223ScriptExecutor.java | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/common/src/main/java/org/apache/hertzbeat/common/entity/dto/PluginUpload.java b/common/src/main/java/org/apache/hertzbeat/common/entity/dto/PluginUpload.java index 5fcabddea..e180f5056 100644 --- a/common/src/main/java/org/apache/hertzbeat/common/entity/dto/PluginUpload.java +++ b/common/src/main/java/org/apache/hertzbeat/common/entity/dto/PluginUpload.java @@ -22,7 +22,6 @@ import jakarta.validation.constraints.NotNull; import lombok.AllArgsConstructor; import lombok.Data; import lombok.NoArgsConstructor; -import org.apache.hertzbeat.common.entity.manager.Collector; import org.springframework.web.multipart.MultipartFile; /** @@ -42,7 +41,7 @@ public class PluginUpload { @NotNull(message = "Enable status is required") private Boolean enableStatus; -// @NotNull(message = "Collector is required") - private Collector collector; + // @NotNull(message = "Collector is required") + // private Collector collector; } diff --git a/common/src/main/java/org/apache/hertzbeat/common/script/executor/Jsr223ScriptExecutor.java b/common/src/main/java/org/apache/hertzbeat/common/script/executor/Jsr223ScriptExecutor.java index ae42bf720..ff8b42c5d 100644 --- a/common/src/main/java/org/apache/hertzbeat/common/script/executor/Jsr223ScriptExecutor.java +++ b/common/src/main/java/org/apache/hertzbeat/common/script/executor/Jsr223ScriptExecutor.java @@ -28,8 +28,6 @@ import javax.script.ScriptException; import javax.script.SimpleBindings; import lombok.extern.slf4j.Slf4j; import org.apache.hertzbeat.common.script.ScriptExecutor; -import org.apache.hertzbeat.common.support.exception.ScriptLoadException; -import org.graalvm.polyglot.Source; /** * JSR223 script engine --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
