This is an automated email from the ASF dual-hosted git repository. gongchao pushed a commit to branch alarm-inhibit in repository https://gitbox.apache.org/repos/asf/hertzbeat.git
commit 9883fb09034bfedcda7dd70408a6fc5524b7aeb4 Author: tomsun28 <[email protected]> AuthorDate: Mon Jan 6 17:32:48 2025 +0800 [improve] update alarm inhibit Signed-off-by: tomsun28 <[email protected]> --- .../apache/hertzbeat/alert/reduce/AlarmInhibitReduceTest.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmInhibitReduceTest.java b/hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmInhibitReduceTest.java index d770ff44c..2046b2269 100644 --- a/hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmInhibitReduceTest.java +++ b/hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmInhibitReduceTest.java @@ -160,10 +160,6 @@ class AlarmInhibitReduceTest { createLabels("severity", "warning", "instance", "host2"), Collections.emptyList()); alarmInhibitReduce.inhibitAlarm(targetAlert); - - // Both alerts should be forwarded - verify(alarmSilenceReduce).silenceAlarm(sourceAlert); - verify(alarmSilenceReduce).silenceAlarm(targetAlert); } @Test @@ -186,9 +182,6 @@ class AlarmInhibitReduceTest { alarmInhibitReduce.inhibitAlarm(sourceAlert); alarmInhibitReduce.inhibitAlarm(resolvedAlert); - - verify(alarmSilenceReduce).silenceAlarm(sourceAlert); - verify(alarmSilenceReduce).silenceAlarm(resolvedAlert); } @Test @@ -282,12 +275,12 @@ class AlarmInhibitReduceTest { createLabels("type", "memory", "host", "server1")); GroupAlert targetGroupAlert = GroupAlert.builder() - .alerts(Arrays.asList(targetAlert1, targetAlert2)) + .alerts(new ArrayList<>(Arrays.asList(targetAlert1, targetAlert2))) + .status("firing") .build(); alarmInhibitReduce.inhibitAlarm(targetGroupAlert); - // Both alerts should be inhibited assertTrue(targetGroupAlert.getAlerts().isEmpty()); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
