This is an automated email from the ASF dual-hosted git repository.

gongchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hertzbeat.git


The following commit(s) were added to refs/heads/master by this push:
     new 7e158eb778 [Improve] Add more test cases for Kafka junit tests (#2976)
7e158eb778 is described below

commit 7e158eb778ace730f92d568d14a45558a0bc7bb8
Author: Nick Guo <[email protected]>
AuthorDate: Sat Jan 11 17:05:04 2025 +0800

    [Improve] Add more test cases for Kafka junit tests (#2976)
    
    Co-authored-by: tomsun28 <[email protected]>
---
 .../hertzbeat/collector/collect/kafka/KafkaCollectTest.java  | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/hertzbeat-collector/hertzbeat-collector-kafka/src/test/java/org/apache/hertzbeat/collector/collect/kafka/KafkaCollectTest.java
 
b/hertzbeat-collector/hertzbeat-collector-kafka/src/test/java/org/apache/hertzbeat/collector/collect/kafka/KafkaCollectTest.java
index c255fc677d..93917a15b4 100644
--- 
a/hertzbeat-collector/hertzbeat-collector-kafka/src/test/java/org/apache/hertzbeat/collector/collect/kafka/KafkaCollectTest.java
+++ 
b/hertzbeat-collector/hertzbeat-collector-kafka/src/test/java/org/apache/hertzbeat/collector/collect/kafka/KafkaCollectTest.java
@@ -78,12 +78,20 @@ public class KafkaCollectTest {
             collect.collect(builder, null);
         });
 
+        KafkaProtocol kafka = 
KafkaProtocol.builder().host("127.0.0.1").port("9092").build();
+        Metrics metrics = Metrics.builder().kclient(kafka).build();
+        //test if not kafka command
         assertDoesNotThrow(() -> {
             CollectRep.MetricsData.Builder builder = 
CollectRep.MetricsData.newBuilder();
-            KafkaProtocol kafka = 
KafkaProtocol.builder().host("127.0.0.1").port("9092").build();
-            Metrics metrics = Metrics.builder().kclient(kafka).build();
             collect.collect(builder, metrics);
         });
+        //test kafka command
+        assertDoesNotThrow(() -> {
+            CollectRep.MetricsData.Builder builder = 
CollectRep.MetricsData.newBuilder();
+            metrics.getKclient().setCommand("topic-list");
+            collect.collect(builder, metrics);
+        });
+
     }
 
     @Test


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to