Rancho-7 opened a new pull request, #3189:
URL: https://github.com/apache/hertzbeat/pull/3189

   Previously, the test relied on `assertThrows` to verify behavior, but the 
actual system uses status codes. To align with the real system's behavior, we 
should verify the same way the system does. This PR fixes this issue.
   
   Additionally, other tests (like `RocketmqSingleCollectTest`) follow the same 
pattern. If agreed, I’d be happy to help fix those as well.
   
   ## Checklist
   
   - [x]  I have read the [Contributing 
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [ ]  I have written the necessary doc or comment.
   - [ ]  I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e 
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have 
passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to