Aias00 opened a new pull request, #3363: URL: https://github.com/apache/hertzbeat/pull/3363
Potential fix for [https://github.com/apache/hertzbeat/security/code-scanning/85](https://github.com/apache/hertzbeat/security/code-scanning/85) To fix the SSRF vulnerability, we need to validate the `SlackWebHookUrl` before using it in the HTTP request. The best approach is to restrict the URL to a known set of safe domains (e.g., Slack webhook domains). If the URL does not match the allowed domains, the request should be rejected. Steps to implement the fix: 1. Add a validation method to check if the `SlackWebHookUrl` belongs to a predefined list of allowed domains (e.g., `hooks.slack.com`). 2. Call this validation method in the `send` method of `SlackAlertNotifyHandlerImpl` before making the HTTP request. 3. If the validation fails, log a warning and throw an `AlertNoticeException`. --- _Suggested fixes powered by Copilot Autofix. Review carefully before merging._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
