bigcyy commented on PR #3482: URL: https://github.com/apache/hertzbeat/pull/3482#issuecomment-2991704957
> > > > Thank you for your PR. I think there are no problems overall. I have carefully reviewed [Logical/set binary operators](https:prometheus.io/docs/prometheus/latest/querying/operators/#logicalset-binary-operators). After comparing the current expression logic, I think we still need to modify `or`, `unless`, and `logical expressions` in the future. > > > > > > > > > Hi, after you spoke, I specifically went to check, and I think you are right. There is indeed such an issue with `or` and `unless`. I can try to fix `unless`, but I would like to get familiar with the collaborative process on GitHub first. Could you please tell me how I can collaborate with you on the development? 😄 > > > > > > Hi, regarding collaborating on development, my understanding is this: After this PR is merged, we can create a new issue and describe the three To-Dos (`or`, `unless`, and `logical expressions`). Then, anyone in the community who is interested can participate in the development. > > What I mean is, I can add you as a collaborator in the forked repository, and we can make changes on a shared branch, or you can submit a PR to my repository, and finally submit a PR to the main repository. Is this how I understand it? I think it's more suitable to create a new issue after this PR is merged. The benefit of doing so is that we can track the feature development in more detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
