Carpe-Wang commented on code in PR #3481:
URL: https://github.com/apache/hertzbeat/pull/3481#discussion_r2159839990
##########
hertzbeat-alerter/src/main/java/org/apache/hertzbeat/alert/notice/impl/AbstractAlertNotifyHandlerImpl.java:
##########
@@ -113,6 +119,19 @@ protected String escapeJsonStr(String jsonStr){
return sb.toString();
}
+ protected CompletableFuture<Void>
sendAsync(org.apache.hertzbeat.common.entity.alerter.NoticeReceiver receiver,
+
org.apache.hertzbeat.common.entity.alerter.NoticeTemplate noticeTemplate,
+ GroupAlert alert) {
+ return CompletableFuture.runAsync(() -> {
+ try {
+ send(receiver, noticeTemplate, alert);
+ } catch (Exception e) {
+ log.error("Async alert notification failed", e);
+ throw new RuntimeException(e);
+ }
+ }, restTemplateThreadPool);
+ }
Review Comment:
I have deleted this piece of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org
For additional commands, e-mail: notifications-h...@hertzbeat.apache.org
