bigcyy commented on issue #3496: URL: https://github.com/apache/hertzbeat/issues/3496#issuecomment-3000530508
It seems that full PromQL support is necessary, then? If so, the approach of setting the value to `null` will need to be changed. Perhaps we can take the result of each periodic threshold expression evaluation and compare it against the metrics that are currently in an alerting state. If a metric for an active alert does not appear in the expression evaluation result, we can conclude that it has recovered. This would eliminate the need to use `null` for this determination. @Duansg Additionally, regarding the minor bug mentioned yesterday, I simply modified the PromQL grammar in the .g4 file: I deleted the line `promql binaryOperator promql` and then regenerated the corresponding lexer and parser code. If you have already modified this part of the code, we can just use your version. I'll wait for your next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: notifications-h...@hertzbeat.apache.org
