Duansg commented on code in PR #3735: URL: https://github.com/apache/hertzbeat/pull/3735#discussion_r2341506370
########## hertzbeat-manager/src/main/java/org/apache/hertzbeat/manager/controller/MetricsFavoriteController.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hertzbeat.manager.controller; + +import com.usthe.sureness.subject.SubjectSum; +import com.usthe.sureness.util.SurenessContextHolder; +import io.swagger.v3.oas.annotations.Operation; +import io.swagger.v3.oas.annotations.Parameter; +import io.swagger.v3.oas.annotations.tags.Tag; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.apache.hertzbeat.common.entity.dto.Message; +import org.apache.hertzbeat.manager.service.MetricsFavoriteService; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.DeleteMapping; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.PathVariable; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; + +import java.util.Set; + +import static org.apache.hertzbeat.common.constants.CommonConstants.FAIL_CODE; +import static org.apache.hertzbeat.common.constants.CommonConstants.LOGIN_FAILED_CODE; + +/** + * Metrics Favorite Controller + */ +@Tag(name = "Metrics Favorite API") +@RestController +@RequestMapping(path = "/api/metrics/favorite") +@RequiredArgsConstructor +@Slf4j +public class MetricsFavoriteController { + + private final MetricsFavoriteService metricsFavoriteService; + + @PostMapping("/{monitorId}/{metricsName}") + @Operation(summary = "Add metrics to favorites", description = "Add specific metrics to user's favorites") + public ResponseEntity<Message<Void>> addMetricsFavorite( + @Parameter(description = "Monitor ID", example = "6565463543") @PathVariable Long monitorId, + @Parameter(description = "Metrics name", example = "cpu") @PathVariable String metricsName) { + String user = getCurrentUser(); + if (user == null) { + return ResponseEntity.ok(Message.fail(LOGIN_FAILED_CODE, "User not authenticated")); + } + try { + metricsFavoriteService.addMetricsFavorite(user, monitorId, metricsName); + return ResponseEntity.ok(Message.success("Metrics added to favorites successfully")); + } catch (Exception e) { Review Comment: > There isn't a specific reason. I think it is better to let `org.apache.hertzbeat.manager.support.GlobalExceptionHandler#handleUnknownException` return error message with status code `500`. Could you help to change it as well? @Calvin979 Thank you for your reply. Of course, I was initially concerned that some definitions of uniform exceptions might differ, potentially violating current specification definitions, so I sought your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: notifications-h...@hertzbeat.apache.org
