Jetiaime commented on PR #3797: URL: https://github.com/apache/hertzbeat/pull/3797#issuecomment-3350828573
> Hi, I have a suggestion to discuss with you, This implementation maybe too specific. how about allowing users to set arbitrary http headers, which can cover more authorizations like Basic/Bearer or company-specific authorization headers. Yeah, I consider about it, but there are some problems we need to solve first: If we allow users to pass the whole headers, it may passed it as a HashMap, there is not have a good way to render it in the frontend. I prefer a simple feature for now, to keep the authentication part simple (user may enter a whole json string or add key-value table like the notifier rules, there is more complexity). And because I'm new to this project, So I wanna to push a simple feature first, then we can discuss more about the headers part. What do you think? If you can help to implement it, that would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
