Duansg commented on PR #3792: URL: https://github.com/apache/hertzbeat/pull/3792#issuecomment-3385761829
> > > Yes, I believe using UTF-8 can fully meet the requirement of supporting all languages worldwide for label values! Moreover, I suggest that this setting should not be limited only to label values; in this way, non-English content can be used in many other scenarios, achieving full universality and getting it right in one go. > > > > > > The Prometheus specification explicitly stipulates that metric names and label names must only use `[a-zA-Z0-9_:]` and does not support Chinese characters. If we were to support Chinese metric names in Hertzbeat, it would cause exported data to become unrecognizable by ecosystem tools like Prometheus/Grafana, thereby breaking compatibility. > > A more reasonable approach is to maintain standardization while implementing Chinese-friendly features through `label value`, metadata mapping, or the frontend presentation layer. This approach adheres to the Prometheus specification while also meeting users' need for Chinese readability. > > Sorry, I missed this. Do we need to discuss this PR again? Hi @tomsun28, yes, i believe there are still some issues in this PR that require priority attention, such as: 1. Excessive object creation and unnecessary boxing/unboxing. 2. Incorrect exception fallback strategy. 3. Redundant inspections and existing performance issues. I've addressed them in #3810. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
