Re: [I] [BUG] instance why use id? [hertzbeat]</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=notifications@hertzbeat.apache.org&q=from:%22via+GitHub%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">via GitHub</span></span></a></span> <span class="date"><a href="/search?l=notifications@hertzbeat.apache.org&q=date:20251121" rel="nofollow">Fri, 21 Nov 2025 07:16:14 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Saramanda9988 commented on issue #3765: URL: <a rel="nofollow" href="https://github.com/apache/hertzbeat/issues/3765#issuecomment-3563454721">https://github.com/apache/hertzbeat/issues/3765#issuecomment-3563454721</a></pre><pre> Hi, community I’ve completed the initial development for this refactor and would like to provide an update, along with a few design questions that came up during the implementation. I hope to get your feedback. 1. Originally, I planned to follow the proposed refactor and use instance as the main query field. However, in the current implementation, multiple monitors may point to the same instance, and the backend does not enforce uniqueness on the instance field. So using it as a lookup key could lead to ambiguous or duplicated results.For this reason, I kept using monitorId internally for querying to ensure deterministic behavior.I’d like to confirm whether monitorId for querying could be the intended design. 2. During the implementation, I noticed differences among storage types: When using VictoriaMetrics, an additional host field which is returned to the frontend. <img width="527" height="416" alt="Image" src="<a rel="nofollow" href="https://github.com/user-attachments/assets/b5a7c599-a539-4a27-92fd-885a9cbfad17"">https://github.com/user-attachments/assets/b5a7c599-a539-4a27-92fd-885a9cbfad17"</a>; /> <img width="889" height="430" alt="Image" src="<a rel="nofollow" href="https://github.com/user-attachments/assets/d3bc87eb-c984-4970-8c3d-88157f3822d6"">https://github.com/user-attachments/assets/d3bc87eb-c984-4970-8c3d-88157f3822d6"</a>; /> When using GreptimeDB, there is no host field. <img width="529" height="420" alt="Image" src="<a rel="nofollow" href="https://github.com/user-attachments/assets/a938adda-e7aa-4f38-9ca9-7ab9c6a62f31"">https://github.com/user-attachments/assets/a938adda-e7aa-4f38-9ca9-7ab9c6a62f31"</a>; /> 3. For the other five TSDB types, the meaning of “instance” is represented through labels, not the instance host like VictoriaMetrics or GreptimeDB. <img width="850" height="438" alt="Image" src="<a rel="nofollow" href="https://github.com/user-attachments/assets/a1e52d5e-bf66-4166-a701-9b966aae5e42"">https://github.com/user-attachments/assets/a1e52d5e-bf66-4166-a701-9b966aae5e42"</a>; /> However, the frontend does not use labels for filtering, and the query parameters do not include an instance field. <img width="875" height="434" alt="Image" src="<a rel="nofollow" href="https://github.com/user-attachments/assets/b0ab006e-1a09-4388-a6fd-e540bdb18e02"">https://github.com/user-attachments/assets/b0ab006e-1a09-4388-a6fd-e540bdb18e02"</a>; /> I’m unsure what the expected unified behavior should be. Should each datasource normalize its own label mappings, or do we want a unified abstraction? I would appreciate guidance on the intended direction here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: notifications-h...@hertzbeat.apache.org </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg14073.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd4.html#14196">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#14196">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg14203.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg13571.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13614.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13802.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg13885.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14044.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14045.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14059.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14069.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14071.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14073.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email tSliceCur"><span class="subject">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14203.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14210.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14217.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14220.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg14297.html">Re: [I] [BUG] <title>instance why use id? [hertzbeat]</a></span> <span class="sender italic">via GitHub</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: [I] [BUG] <title>instance why use id? [hertzbeat]"> <input type="hidden" name="msgid" value="I_kwDOGyeqAs7LNdbF-ceec027f-8fc9-438b-8d32-6f9f3fe9a5f3@gitbox.apache.org"> <input type="hidden" name="relpath" value="notifications@hertzbeat.apache.org/msg14196.html"> <input type="submit" value=" via GitHub "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="notifications@hertzbeat.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search notifications"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/notifications@hertzbeat.apache.org/">notifications - all messages</a></li> <li class="icons-about"><a href="/notifications@hertzbeat.apache.org/info.html">notifications - about the list</a></li> <li class="icons-expand"><a href="/search?l=notifications@hertzbeat.apache.org&q=subject:%22Re%5C%3A+%5C%5BI%5C%5D+%5C%5BBUG%5C%5D+%3Ctitle%3Einstance+why+use+id%5C%3F+%5C%5Bhertzbeat%5C%5D%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg14073.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg14203.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">I_kwDOGyeqAs7LNdbF-ceec027f-8fc9-438b-8d32-6f9f3fe9a5f3@gitbox.apache.org</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9eb6f55168bf2308',t:'MTc3NjA0NjQ3Nw=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>