aiai-bot commented on PR #3965:
URL: https://github.com/apache/hertzbeat/pull/3965#issuecomment-3748110883
<!-- code-pr-reviewer -->
## Blocking Issue
**`home/docs/help/http_sd.md` - Incorrect API response format**
The documented HTTP API response format doesn't match the implementation.
The code expects a **JSON array** of `ServiceDiscoveryResponseEntity` objects,
but the docs show a single object with a `targets` field.
**Documented (incorrect):**
```json
{
"targets": ["192.168.1.101:8080", "192.168.1.102:8080"]
}
```
**Actual expected (per `HttpSdCollectImpl.java:86-94`):**
```json
[{
"target": ["192.168.1.101:8080", "192.168.1.102:8080"]
}]
```
This affects all HTTP SD examples. Users following the docs will have
non-functional service discovery.
## Suggestions
1. Verify all doc examples against implementations
2. Add integration tests validating documented API formats
LGTM otherwise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
