Duansg commented on PR #3985:
URL: https://github.com/apache/hertzbeat/pull/3985#issuecomment-3772389673
@zqr10159 hi, thank you for inviting me to review.
> The current parsing rules for PromQL metrics and labels are as follows:
`[a-zA-Z_] [a-zA-Z0-9_=～{}[\]".~-]* `
In the Examples section, `cpu_usage{instance='server1'} > 80` should be
replaced with `cpu_usage{instance="server1"} > 80`
> On the page for adding a new threshold, are the warnings overly redundant?
The current situation is as follows:
<img width="1136" height="423" alt="Snipaste_2026-01-20_17-07-20"
src="https://github.com/user-attachments/assets/d055e794-f0de-423b-94c6-5ab14915999a";
/>
Can we adjust the style? Let's change it to something like this:
<img width="1269" height="509" alt="Snipaste_2026-01-20_19-10-42"
src="https://github.com/user-attachments/assets/b9bcaf53-c627-4a70-91a5-88db29a35abc";
/>
I'd like to hear your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
