yuluo-yx commented on code in PR #4048:
URL: https://github.com/apache/hertzbeat/pull/4048#discussion_r2868886527
##########
hertzbeat-common-core/src/main/java/org/apache/hertzbeat/common/entity/job/protocol/DnsSdProtocol.java:
##########
@@ -30,12 +30,19 @@
@AllArgsConstructor
@NoArgsConstructor
public class DnsSdProtocol implements Protocol {
-
+
private String host;
private String port;
private String recordType;
private String recordName;
+
+ @Override
+ public boolean isInvalid() {
+
+ // todo: add
Review Comment:
i think we can improve on this later; there's so much more to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
