abhyudayareddy commented on PR #4104: URL: https://github.com/apache/hertzbeat/pull/4104#issuecomment-4158553128
Hi @Duansg, thanks for reviewing! To clarify the distinction: issue #1945 is about HertzBeat itself acting as a Prometheus remote write *storage* backend — i.e., other systems pushing metrics *into* HertzBeat via the remote write protocol. That is a different feature entirely. This PR adds a **monitoring template** so that HertzBeat can *monitor* external services that expose a Prometheus Remote Write receiver endpoint (e.g., Thanos Receive, Cortex, Mimir, VictoriaMetrics). HertzBeat scrapes their `/metrics` endpoint using its existing `parseType: prometheus` HTTP collection — no protocol adapter is needed. In short: - Issue #1945: HertzBeat **receives** remote write data (storage protocol) - - This PR: HertzBeat **monitors** remote write receiver services (observability template) The `Closes/relates to #1945` line in the PR description was meant as a loose reference to the same ecosystem; I can remove it to avoid confusion if that's clearer. Let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
