Duansg commented on PR #4104: URL: https://github.com/apache/hertzbeat/pull/4104#issuecomment-4160362299
@abhyudayareddy Hi, overall, this PR has the following issues: 1. This PR has not advanced #1945 2. There are numerous errors in the current template. 3. If the goal is simply to collect data from the `metrics` endpoint, this is already supported. I don’t think there’s a need to add an additional template. Given this, I cannot approve this PR. @zqr10159 could you please review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
