moduvoice opened a new pull request, #4197: URL: https://github.com/apache/hertzbeat/pull/4197
# Korean (ko) translation PR body template ## Motivation This adds Korean (`ko`) translation support — to help Korean-speaking users use this open-source project more comfortably in their own language. 한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다. ## Changes Adds Korean translation across both the web-app UI and the docs site (1509 keys total): - `web-app/src/assets/i18n/ko-KR.json` — full Korean translation of the web-app UI (1241/1241 keys, full parity with `en-US.json`) - `web-app/src/app/core/i18n/i18n.service.ts` — registers `ko-KR` as a selectable language (Angular/date-fns/ng-zorro-antd/@delon locale wiring), following the same pattern used for `ja-JP` - `web-app/src/app/layout/basic/directives/setting-drawer-i18n.directive.ts` — adds `ko-KR` to the languages list used by the settings-drawer live-translation directive - `web-app/src/app/layout/basic/directives/setting-drawer-i18n.directive.spec.ts` — updates the existing spec to mock/assert the new `ko-KR` HTTP request alongside the existing locales - `home/i18n/ko/**` — Korean translation for the Docusaurus docs site chrome (code.json, navbar, footer, docs sidebar labels for `current` and `version-1.8.0`, blog options) — 268/268 keys, full parity with the `en` source - `home/docusaurus.config.js` — registers `ko` in the Docusaurus `i18n.locales` list Brand/product names (HertzBeat, GitHub, ASF), API/field identifiers, and technical terms (e.g. NGQL) were intentionally left untranslated, consistent with the existing `ja-JP.json`/`pt-BR.json` pattern. ## Testing - Programmatically verified key parity: `ko-KR.json` vs `en-US.json` → 1241/1241 keys match, no missing/extra/empty values. - Programmatically verified key parity for all 6 docs-site `ko` files against their `en` counterparts → 268/268 keys match. - Reviewed `setting-drawer-i18n.directive.spec.ts` — the updated spec correctly mocks the new `./assets/i18n/ko-KR.json` HTTP request in the same position as the other locales and its `httpMock.verify()` expectations are consistent with the directive change. - Spot-checked monitoring/DevOps terminology for consistency (e.g. 임계값 for threshold, 수집기 for collector, 알람 for alert vs 알림 for notification). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
