zqr10159 commented on PR #4263: URL: https://github.com/apache/hertzbeat/pull/4263#issuecomment-5129895733
I rechecked the current head (14382fff). This change protects the key-distribution path, but it does not authenticate the Netty peer or any ClusterMsg.Message: unsigned GO_ONLINE, heartbeat, and collection-result messages still reach their processors. In particular, GO_ONLINE can still replace the identity-to-channel mapping, and cyclic results still enter the data queue without a message-integrity check. I opened the dependent follow-up #4294. It signs the complete message envelope, enforces timestamp freshness and replay rejection, and closes invalid connections before processor dispatch. For this transport boundary, I would only treat #4263 plus #4294 (or an equivalent combined implementation) as complete. The rollout remains intentionally breaking: manager and standalone Collector must be upgraded together, share common.secret, and keep clocks synchronized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
