zqr10159 commented on PR #4292: URL: https://github.com/apache/hertzbeat/pull/4292#issuecomment-5179620412
Addressed the review findings in commit `68b340d4b0`. Changes: - create and update now use operation-specific name validation; - create rejects an existing name regardless of a caller-supplied ID; - update requires an ID and permits only the same record to retain its name; - added a database unique constraint as the final concurrent-write boundary. Human validation: - `BulletinServiceTest,BulletinControllerTest` (11 tests passed); - `git diff --check`. The new-head backend, Maven E2E, license, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: deployments with pre-existing duplicate bulletin names must clean those rows before schema validation can succeed. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
