zqr10159 commented on PR #4293: URL: https://github.com/apache/hertzbeat/pull/4293#issuecomment-5179620751
Addressed the review findings in commit `a920268d2b`. Changes: - removed the unconditional startup migration that could silently opt future policy-less SFTP rows into `insecureSkipVerify`; - validate configured fingerprints as `SHA256:base64`; - pass Apache SSHD's SHA-256 digest factory explicitly rather than relying on its mutable global default; - aligned the conditional UI wording and operator docs with the fingerprint-or-explicit-dangerous-skip contract; - documented that HertzBeat never enables skip-verification automatically. Human validation: - `FtpCollectImplTest,FtpProtocolTest` passed across common-core and collector-basic, with manager compilation included; - the digest regression changes SSHD's global default to MD5 and still proves SHA-256 verification; - `git diff --check`. The new-head backend, Maven E2E, license, docs, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: operators choosing the explicit skip-verification option still accept MITM risk, and the collector logs that state. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
