zqr10159 commented on PR #4289: URL: https://github.com/apache/hertzbeat/pull/4289#issuecomment-5179620091
Addressed the review findings in commit `ab4fc80bd0`. Changes: - both VictoriaMetrics storage modes retain failed batches and retry them after one second; - periodic scheduling is restored from `finally` after failures; - immediate flushes drain bounded bursts per callback and reschedule while work remains; - producer backpressure is bounded when a failed retry batch and the queue remain full, with cumulative, rate-limited drop diagnostics rather than an infinite wait; - timer resolution was reduced to 100 ms so healthy concurrent bursts do not stall behind one-second scheduling gaps. Human validation: - the existing 100-thread healthy-write regression passed; - full `VictoriaMetricsDataStorageTest,VictoriaMetricsClusterDataStorageTest` suites passed, including failed-batch retry and persistent-failure non-blocking cases; - `git diff --check`. The new-head backend, Maven E2E, license, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: sustained downstream failure can still exhaust the bounded buffer; this is now an explicit counted drop instead of a warehouse-thread deadlock. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
