zqr10159 commented on PR #4294: URL: https://github.com/apache/hertzbeat/pull/4294#issuecomment-5179628910
Addressed the actionable review findings in commit `5428958ef9`. Changes: - channel nonces are established with compare-and-set; a second well-formed `AUTH_CHALLENGE` is counted as replay, rejected, and cannot re-pin the connection; - the compatibility test now labels new-Manager/old-Collector as transport-only; - a credentialed `WheelTimerTask` regression proves that upgrading Manager first leaves an old Collector unable to decrypt Manager-encrypted parameters; - the operator and upgrade guides now make Collector-first order mandatory and explicitly state why heartbeat compatibility is insufficient; - the replay section now documents the 65,536-entry cache's capacity-eviction degradation inside the clock-skew window. Human validation: - `NettyRemotingAuthenticationTest`, `NettyRemotingCompatibilityTest`, `ClusterMessageAuthenticatorTest`, and `GoOnlineProcessorTest` passed with reactor dependencies; - `git diff --check`; - a temporary local 1 MiB payload microbenchmark (100 sign+verify iterations, three fresh JVM runs) measured 499.09, 502.22, and 563.68 MiB/s, with 3.44x-6.98x cost versus plain protobuf serialization. The benchmark source was not committed. The new-head backend, Maven E2E, license, docs, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: the Collector startup compatibility break is now prominent and executable in tests/docs, but accepting that release break remains a PMC decision. The README and `.gitignore` changes are retained because the later packaging fix now requires users to provision private install secrets safely. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
