orangeCatDeveloper opened a new pull request, #4309:
URL: https://github.com/apache/hertzbeat/pull/4309

   ## What's changed?
   
   Fixes #1594: a metric group with hundreds of rows (the issue reports 200 
statuses) renders as one unbounded scroll blob in the monitor detail card — the 
maintainer asked to "support pageable in monitoring metrics data table ui".
   
   Changes in `monitor-data-table`:
   
   - enable front pagination on the row table: pager appears above 10 rows, 
with a page size changer (10/20/50/100)
   - page index resets when the data reloads or the page size changes, so 
switching metrics can never strand the user on a stale page
   - the vertical scroll budget shrinks while the pager is visible, so it is 
not clipped by the fixed-height card (`nzBodyStyle` uses `overflow: hidden` 
there)
   - `valueRows` is initialized to `[]` — the new template expression evaluates 
before the async load returns
   - the single-row name/value table and the fullscreen modal (which reuses the 
same template, pagination included) are unaffected
   
   Verified against a real deployment with a 200-row metric group: pager 
renders inside the card and the modal, page 3 shows rows 21–30, switching to 
50/page resets to page 1 with 4 pages. Before/after screenshots below.
   
   ## Checklist
   
   - [x]  I have read the [Contributing 
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [x]  I have written the necessary doc or comment.
   - [ ]  I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e 
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have 
passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to