Duansg commented on code in PR #4320:
URL: https://github.com/apache/hertzbeat/pull/4320#discussion_r3789723840
##########
hertzbeat-common-core/src/main/java/org/apache/hertzbeat/common/entity/job/protocol/KafkaProtocol.java:
##########
@@ -74,6 +113,16 @@ public boolean isInvalid() {
&& !"false".equalsIgnoreCase(monitorInternalTopic)) {
return true;
}
- return false;
+ if (StringUtils.isNotBlank(securityProtocol)
+ &&
!SECURITY_PROTOCOLS.contains(securityProtocol.toUpperCase(Locale.ROOT))) {
+ return true;
+ }
+ if (!hasSaslAuthentication()) {
+ return StringUtils.isNotBlank(saslMechanism)
+ || StringUtils.isNotBlank(username)
+ || StringUtils.isNotBlank(password);
Review Comment:
Could this cause the existing monitoring to become unavailable after the
upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
