orangeCatDeveloper commented on PR #4265: URL: https://github.com/apache/hertzbeat/pull/4265#issuecomment-5309640579
Thanks for the careful review! I double-checked the must-fix point against the json-path 2.9.0 sources: `Configuration#addOptions` copies the option set and returns a **new** instance via `Configuration.builder()...build()` — the class is documented as immutable — so `PARSER` never inherits `SUPPRESS_EXCEPTIONS`. A runtime check confirms it: `conf != conf.addOptions(...)`, and the original `conf` still holds only `[DEFAULT_PATH_LEAF_TO_NULL, ALWAYS_RETURN_LIST]`. To make that contract explicit I added the regression test you suggested — `JsonPathParserTest#parseContentWithJsonPathStillThrowsWhenPathMissing` — pinning that `parseContentWithJsonPath` still throws `PathNotFoundException` on a missing path. Also added short comments for the two minor notes (alias exact-match contract, multi-value wildcard rendering). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
