hutiefang76 commented on PR #4168: URL: https://github.com/apache/hertzbeat/pull/4168#issuecomment-5398844408
Thanks for the review. I rechecked the current head and confirmed the three points are covered: - `sendGroupAlert(...)` now falls back to `DEFAULT_REPEAT_INTERVAL` when the cached group rule has been removed; `cachedGroupUsesDefaultRepeatIntervalWhenGroupRuleWasRemoved` covers that path. - Historical group-alert lookup is only performed for an incoming `resolved` group, so firing updates do not add the extra database query; `storeFiringGroupDoesNotQueryHistoricalAlerts` covers it. - When a resolved member arrives while another member is still firing, the persisted group is recalculated from the complete stored member set and the returned `GroupAlert` carries that complete alert list; `storeResolvedAlertKeepsGroupFiringWhenOtherGroupAlertsStillFire` covers it. I reran `AlarmGroupReduceTest` and `DbAlertStoreHandlerImplTest` from the reactor with a Central-only Maven configuration: 11 tests passed, 0 failures/errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
