zqr10159 commented on PR #4368: URL: https://github.com/apache/hertzbeat/pull/4368#issuecomment-5567741066
Clarification on the test request: there is no requirement to commit the separate local harness itself. The repository’s existing Maven E2E framework can cover this properly. Please add a focused `hertzbeat-startup-e2e` module under `hertzbeat-e2e`, add it to `hertzbeat-e2e/pom.xml`, and include it in the `backend-maven-e2e` module list in `.github/workflows/backend-build-test.yml`. The E2E parent already provides Testcontainers, and the repository already uses the MySQL/PostgreSQL Testcontainers modules and JDBC drivers. The test should use in-memory H2 plus MySQL and PostgreSQL containers, run the repository Flyway configuration from a V180 baseline to V190, and verify the resulting data/schema state and a clean second startup. In particular, assert the ownerless/owned schedule behavior, final `expr` type, index uniqueness, MySQL procedure cleanup, and Flyway current version V190. A small migration-inventory assertion should also ensure the three dialect directories contain V190 rather than the discarded intermediate migration files. This gives us reproducible CI evidence without promoting a one-off local test tool into the codebase. The earlier request to remove the old migration-number narrative from the V190 files and PR description still applies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
