Duansg opened a new pull request, #4381:
URL: https://github.com/apache/hertzbeat/pull/4381
## What's changed?
### Why
Releasing 1.9.0 exposed several problems in these guides. The most costly
one: the signing loop and the verification loop both matched `*.tar.gz` only,
so the windows-amd64 native collector package went into the RC2 vote with no
signature and no checksum, and neither side would have caught it.
### What changed
**Release guide**
- fix two commands that fail as written: the collector directory does not
exist, and `-pl hertzbeat-collector-collector` is rejected by Maven
- replace the personal details of two different release managers with
placeholders, listed in a table at the top
- sign `*.zip` too, and add a loop that reports any artifact missing a
`.asc` or `.sha512`
- add a note to start each native package once before signing it
**Verification guide**
- verify `*.zip` too
- add a section for the native collector packages: they cannot be built from
source, so check that they start and stay up
- rewrite the "trust the public key" section — verifying a signature does
not require trust, and marking someone else's key ultimate is wrong
- fix backticks in the download commands (the shell runs them as command
substitution), a self-referencing checklist item, and a stray dash in the KEYS
command
**Native collector requirements**
- document AVX2, glibc 2.34 and the Windows VC++ redistributable, plus what
each unmet requirement looks like — without AVX2 the process exits instantly
with no output, which reads as a corrupted download
- link to it from the 1.9.0 upgrade guide
**Rendering fix**
- `{version}` in headings and prose was evaluated as a JS variable by MDX,
so the Chinese release guide rendered only `version is not defined`
English and Chinese versions are kept in sync. Worth opening the pages once
before merging — the MDX error is invisible in the diff.
<img width="1505" height="858" alt="image"
src="https://github.com/user-attachments/assets/ab761533-f78f-4524-8fca-bfa230eee80f";
/>
## Checklist
- [x] I have read the [Contributing
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
- [x] I have written the necessary doc or comment.
- [ ] I have added the necessary unit tests and all cases have passed.
## Add or update API
- [ ] I have added the necessary [e2e
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
