xyy45 commented on PR #4392:
URL: https://github.com/apache/hertzbeat/pull/4392#issuecomment-5770167562
Follow-up on the verification I said I still owed: replayed the request path
from this branch
against a local recording listener (stub upstream returning a canned SSE
completion, throwaway
key, no real provider involved). Same construction and call chain
`streamChat` uses:
`LlmConfig.buildChatOptions(...)` ->
`OpenAiChatModel.builder().options(...)` -> `ChatClient.stream()`.
`"temperature": 0.7` in the provider config:
```json
{"model": "wire-scratch-model", "temperature": 0.7, "stream": true,
"stream_options": {"include_usage": true}, "messages": [...]}
```
`temperature` omitted:
```json
{"model": "wire-scratch-model", "temperature": 0.3, "stream": true,
"stream_options": {"include_usage": true}, "messages": [...]}
```
So the configured value does reach the body and the built-in default still
applies when it is
absent. The other keys are unchanged from what #4391 captured.
And for an unknown `code` with no `baseUrl`/`model`, the warning is what now
tells you instead of
the vendor error:
```
WARN org.apache.hertzbeat.ai.config.LlmConfig -- Model provider code
deepseek has no built-in
defaults, the OpenAI endpoint and model are used instead, please configure
baseUrl and model
explicitly
```
To be precise about scope: this drove the Spring AI request path directly,
not the packaged
application behind the web UI, so I would still call the second part of that
(a full app run)
outstanding. `mvn test -pl hertzbeat-ai` is 69/69 on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]