orangeCatDeveloper commented on issue #1714: URL: https://github.com/apache/hertzbeat/issues/1714#issuecomment-5861053204
For reference, the in-memory queue that the Kafka workaround replaced is still unbounded on master: every queue is a `LinkedBlockingQueue` without a capacity, so when the consumers (alerting or storage) fall behind, collected data keeps piling up in the heap until it runs out of memory. https://github.com/apache/hertzbeat/blob/8104d7057c72f9c18dea31d32e076750d2c34020/hertzbeat-common-spring/src/main/java/org/apache/hertzbeat/common/queue/impl/InMemoryCommonDataQueue.java#L57-L61 Bounding the queues (and dropping or logging on overflow) would prevent the OOM without requiring Kafka. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
