butterfly-520-boy commented on issue #3197: URL: https://github.com/apache/hertzbeat/issues/3197#issuecomment-5869115043
Hi maintainers, I would like to work on this issue. I noticed that another contributor proposed a similar approach earlier, but the issue is still unassigned and I could not find an implementation PR. Could you please confirm whether anyone is still actively working on it? If it is available, my proposed scope is: 1. Replace the unbounded blocking `DatagramChannel.receive()` in `UdpConnection` with a bounded receive timeout, likely using a non-blocking channel and `Selector`. 2. Report the timeout as a clear `IOException`/`SocketTimeoutException` so the current collection can fail instead of leaving the worker blocked. 3. Add a deterministic local UDP regression test covering a server that receives the request but does not send a response. 4. Keep the successful response path covered to avoid breaking normal IPMI communication. One design question before implementation: `IpmiProtocol` currently has no timeout field. Would you prefer an internal default timeout, or should the timeout be exposed in the IPMI monitoring template and protocol configuration? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
