Rangsh commented on PR #4347: URL: https://github.com/apache/hertzbeat/pull/4347#issuecomment-6116368750
@tomsun28 Thanks for the review. The frontend has been rebuilt on the current React app, and the branch is now based on the latest master. The old Angular files (`NoticeReceiver.ts`, alert-notice components, and the old i18n JSON) are no longer part of this change. The receiver form now comes from the React notice-receiver catalog, including the type label, secret field, draft/schema mapping, and the five current locale files. One necessary adjustment: type 16 is already used by WPUSH on master, so Microsoft Teams is now type 17 (`microsoft-teams`) instead of the original type 16. The backend handler, contract mapper, secret masking, default template, docs, and tests are updated to match. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
