dmitrievanthony commented on a change in pull request #5767: [ML] IGNITE-10573:
Consistent API for Ensemble training
URL: https://github.com/apache/ignite/pull/5767#discussion_r247540682
##########
File path:
modules/ml/src/main/java/org/apache/ignite/ml/composition/stacking/StackedDatasetTrainer.java
##########
@@ -402,11 +346,12 @@ public StackedDatasetTrainer() {
IgniteBiFunction<K, V, Vector> featureExtractor,
IgniteBiFunction<K, V, L> lbExtractor) {
// This method is never called, we override "update" instead.
- return null;
+ throw new IllegalStateException();
}
/** {@inheritDoc} */
@Override protected boolean checkState(StackedModel<IS, IA, O, AM> mdl) {
- return true;
+ // Should be never called.
+ throw new IllegalStateException();
Review comment:
Please, update javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
