dmitrievanthony commented on a change in pull request #5767: [ML] IGNITE-10573: 
Consistent API for Ensemble training
URL: https://github.com/apache/ignite/pull/5767#discussion_r247541371
 
 

 ##########
 File path: 
modules/ml/src/main/java/org/apache/ignite/ml/dataset/UpstreamTransformerBuilder.java
 ##########
 @@ -49,11 +47,11 @@
      * @param other Builder to combine with.
      * @return Compositional builder.
      */
-    public default UpstreamTransformerBuilder<K, V> 
andThen(UpstreamTransformerBuilder<K, V> other) {
-        UpstreamTransformerBuilder<K, V> self = this;
+    public default UpstreamTransformerBuilder 
andThen(UpstreamTransformerBuilder other) {
+        UpstreamTransformerBuilder self = this;
         return env -> {
-            UpstreamTransformer<K, V> transformer1 = self.build(env);
-            UpstreamTransformer<K, V> transformer2 = other.build(env);
+            UpstreamTransformer transformer1 = self.build(env);
 
 Review comment:
   Could use `UpstreamTransformerBuilder.this.build(env)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to