artemmalykh commented on a change in pull request #5767: [ML] IGNITE-10573: 
Consistent API for Ensemble training
URL: https://github.com/apache/ignite/pull/5767#discussion_r247885871
 
 

 ##########
 File path: 
modules/ml/src/main/java/org/apache/ignite/ml/trainers/AdaptableDatasetTrainer.java
 ##########
 @@ -56,27 +68,46 @@
      * @param <L> Type of labels.
      * @return Instance of this class.
      */
-    public static <I, O, M extends IgniteModel<I, O>, L> 
AdaptableDatasetTrainer<I, O, I, O, M, L> of(DatasetTrainer<M, L> wrapped) {
-        return new AdaptableDatasetTrainer<>(IgniteFunction.identity(), 
wrapped, IgniteFunction.identity());
+    public static <I, O, M extends IgniteModel<I, O>, L> 
AdaptableDatasetTrainer<I, O, I, O, M, L> of(
+        DatasetTrainer<M, L> wrapped) {
+        return new AdaptableDatasetTrainer<>(IgniteFunction.identity(),
+            wrapped,
+            IgniteFunction.identity(),
+            IgniteFunction.identity(),
+            IgniteFunction.identity(),
+            UpstreamTransformerBuilder.identity());
     }
 
     /**
      * Construct instance of this class with specified wrapped trainer and 
converter functions.
      *
      * @param before Function used to convert input type of wrapped trainer.
-     * @param wrapped  Wrapped trainer.
+     * @param wrapped Wrapped trainer.
      * @param after Function used to convert output type of wrapped trainer.
+     * @param extractor
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to